Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix favicon not rendering properly in google search. #5183

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jun 24, 2024

Done

Updates site to use 48x48 version of the Vanilla logo as a favicon, instead of the old 32x32 version. We are also now serving a favicon locally for search engines, following the practice done by c.com & u.com.

See Google favicon rendering documentation for more information.

Fixes WD-12464, MM thread

QA

Google Recrawl

After this is merged, it may take a few days for the icon to change on Google search results. If it still hasn't been fixed after some time, we should submit a recrawl request which should fix the issue.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

@jmuzina jmuzina self-assigned this Jun 24, 2024
@jmuzina jmuzina marked this pull request as ready for review June 24, 2024 12:22
@jmuzina jmuzina changed the title Use 48x48 favicon; fix favicon not rendering properly in google searc… Fix favicon not rendering properly in google search. Update to CoF logo Jun 24, 2024
@jmuzina
Copy link
Member Author

jmuzina commented Jun 25, 2024

@lyubomir-popov Please provide an export of the new Vanilla logo to use for the favicon, per MM discussion

@jmuzina
Copy link
Member Author

jmuzina commented Jun 26, 2024

@bartaz @pastelcyborg @lyubomir-popov Updated with new logo, please review :)

@jmuzina jmuzina changed the title Fix favicon not rendering properly in google search. Update to CoF logo Fix favicon not rendering properly in google search. Jun 26, 2024
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartaz bartaz added the Question ❓ Further information is requested label Jun 26, 2024
@jmuzina jmuzina removed the Question ❓ Further information is requested label Jun 26, 2024
@lyubomir-popov
Copy link
Contributor

LGTM

@jmuzina jmuzina merged commit 2a328f1 into canonical:main Jun 27, 2024
6 checks passed
@jmuzina jmuzina deleted the fix-google-favicon branch June 27, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants