-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix favicon not rendering properly in google search. #5183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuzina
changed the title
Use 48x48 favicon; fix favicon not rendering properly in google searc…
Fix favicon not rendering properly in google search. Update to CoF logo
Jun 24, 2024
@lyubomir-popov Please provide an export of the new Vanilla logo to use for the favicon, per MM discussion |
jmuzina
force-pushed
the
fix-google-favicon
branch
from
June 26, 2024 13:10
d07c080
to
73600e9
Compare
@bartaz @pastelcyborg @lyubomir-popov Updated with new logo, please review :) |
jmuzina
changed the title
Fix favicon not rendering properly in google search. Update to CoF logo
Fix favicon not rendering properly in google search.
Jun 26, 2024
3 tasks
bartaz
added
Documentation 📝
Documentation changes or updates
Review: QA +1
Review: Code +1
and removed
Bug 🐛
Review: QA needed
Review: Code needed
labels
Jun 26, 2024
bartaz
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
bartaz
reviewed
Jun 26, 2024
This reverts commit cbb83351bf49bd2408278a604001cdaeb2f0cbcd.
This reverts commit 1023897b9a8e9ed5e0b8abb1e9f35e060d0616da.
jmuzina
force-pushed
the
fix-google-favicon
branch
from
June 26, 2024 19:19
67302ae
to
6c5dd5a
Compare
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Updates site to use 48x48 version of the Vanilla logo as a favicon, instead of the old 32x32 version. We are also now serving a favicon locally for search engines, following the practice done by c.com & u.com.
See Google favicon rendering documentation for more information.
Fixes WD-12464, MM thread
QA
Google Recrawl
After this is merged, it may take a few days for the icon to change on Google search results. If it still hasn't been fixed after some time, we should submit a recrawl request which should fix the issue.
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention: