-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new focus theme variable for improved color theme support #5192
Merged
pastelcyborg
merged 6 commits into
canonical:main
from
pastelcyborg:add-focus-theme-variable
Jun 26, 2024
Merged
Add new focus theme variable for improved color theme support #5192
pastelcyborg
merged 6 commits into
canonical:main
from
pastelcyborg:add-focus-theme-variable
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastelcyborg
added
Review: QA needed
Review: Code needed
Maintenance 🔨
Review: Percy needed
This PR needs a review of Percy for visual regressions
labels
Jun 26, 2024
bartaz
reviewed
Jun 26, 2024
This was referenced Jun 26, 2024
jmuzina
removed
the
Review: Percy needed
This PR needs a review of Percy for visual regressions
label
Jun 26, 2024
bartaz
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jmuzina
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
$colors--theme--focus
color variable$color-focus
to$colors--theme--focus
Fixes WD-12630
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention: