Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new focus theme variable for improved color theme support #5192

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

pastelcyborg
Copy link
Contributor

@pastelcyborg pastelcyborg commented Jun 26, 2024

Done

  • Added new $colors--theme--focus color variable
  • Updated all existing uses of $color-focus to $colors--theme--focus

Fixes WD-12630

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

@pastelcyborg pastelcyborg marked this pull request as ready for review June 26, 2024 16:05
scss/_settings_colors.scss Outdated Show resolved Hide resolved
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pastelcyborg pastelcyborg merged commit c77c387 into canonical:main Jun 26, 2024
10 checks passed
@pastelcyborg pastelcyborg deleted the add-focus-theme-variable branch June 26, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants