Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling updates for reduced navigation #5206

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jul 3, 2024

Done

Visual adjustments for reduced navigation:

  • shifting Canonical logo to make it aligned with logo text below it and with nav items on mobile
  • updateing icon colours to use muted colour in reduced nav on desktop

Fixes https://warthogs.atlassian.net/browse/WD-12921
Fixes https://warthogs.atlassian.net/browse/WD-12922

QA

  • Open demo
  • Make sure that chevron and search icons are the same colour as text it top reduced navigation bar
  • Make sure "Canonical Ubuntu" logo text is aligned with Ubuntu text below
  • On small screen open the top "Menu", make sure "Canonical Ubuntu" is aligned with menu items

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details

Screenshots

image image

@webteam-app
Copy link

@bartaz bartaz marked this pull request as draft July 4, 2024 11:15
@bartaz bartaz force-pushed the reduced-nav-logo branch 2 times, most recently from 889b6c4 to b11ab79 Compare July 4, 2024 11:33
@bartaz bartaz added the Review: Percy needed This PR needs a review of Percy for visual regressions label Jul 4, 2024
@bartaz bartaz added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Jul 4, 2024
@bartaz bartaz added the Bug 🐛 label Jul 4, 2024
@bartaz bartaz changed the title WIP: Reduced nav logo Reduced nav logo Jul 4, 2024
@bartaz bartaz marked this pull request as ready for review July 4, 2024 14:59
@bartaz bartaz changed the title Reduced nav logo Styling updates for reduced navigation Jul 4, 2024
@pastelcyborg pastelcyborg self-requested a review July 4, 2024 15:10
@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Jul 4, 2024

Thanks, looks as expected. Let me confirm with Hans that he's ok with it as well.

@bartaz bartaz merged commit 8246de7 into canonical:main Jul 4, 2024
11 checks passed
@lyubomir-popov
Copy link
Contributor

Confirmed, good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants