Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move search into the reduced navigation #5210

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jul 5, 2024

Done

When reduced navigation is used (with secondary navigation) the search is displayed on top of secondary navigation (and used to be defined there in markup). But to simplify templating we want to keep the search in the top (reduced) navigation that triggers it.

This PR addresses it by moving search HTML from secondary nav to top reduced navigation and adjusts the styling to use absolute positioning to display open search on top of the secondary navigation.

Fixes https://warthogs.atlassian.net/browse/WD-13032

QA

  • Open demo
  • Check the search functionality, both on desktop and mobile screen sizes

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
An unrelated note, where did we land on the position of the two logo texts. It looks a little strange as it:
image

@bartaz
Copy link
Member Author

bartaz commented Jul 8, 2024

LGTM! An unrelated note, where did we land on the position of the two logo texts. It looks a little strange as it: image

@petesfrench That's where it landed. To avoid misalignments, or changing it based on having mobile menu open etc, Lyubo decided to just move it to the position where it aligns with other logo text (and menu items) by default. So this is as expected.

@bartaz bartaz merged commit a0d8f34 into canonical:main Jul 9, 2024
12 checks passed
@bartaz bartaz deleted the reduced-search branch July 9, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants