Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in PR template #5225

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jul 16, 2024

Done

Fixes a small typo in the PR template.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

@bartaz bartaz added the Review: Percy needed This PR needs a review of Percy for visual regressions label Jul 17, 2024
@bartaz
Copy link
Member

bartaz commented Jul 17, 2024

Having Percy as a required CI check is a bit unnecessary in cases like this. We are kind of forced to run percy at least once on a PR that it doesn't apply to at all.

But I guess we rarely have such, so it's better to be safe.

@bartaz bartaz merged commit 9ca641e into canonical:main Jul 17, 2024
9 checks passed
@jmuzina jmuzina deleted the fix-pr-template-typo branch August 28, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance 🔨 Review: Code needed Review: Percy needed This PR needs a review of Percy for visual regressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants