Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bots from the contributors list #5233

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

Satishpokala124
Copy link
Contributor

@Satishpokala124 Satishpokala124 commented Jul 21, 2024

Done

Removes bots from the contributors list

Fixes #5098

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

Satishpokala124 is not a collaborator of the repo

@jmuzina
Copy link
Member

jmuzina commented Jul 22, 2024

Hi @Satishpokala124, thanks for the contribution!

Could you update this to also filter out renovate-bot please? It is currently the bot with the most contributions so I'd like to make sure that it is also filtered out by this change.

@Satishpokala124
Copy link
Contributor Author

Hi @jmuzina, the renovate-bot is removed using its login. Let me know if that's ok.

Copy link
Member

@jmuzina jmuzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but this is almost ready to go! :)

webapp/app.py Outdated Show resolved Hide resolved
webapp/app.py Outdated Show resolved Hide resolved
webapp/app.py Show resolved Hide resolved
@jmuzina jmuzina added Review: Percy needed This PR needs a review of Percy for visual regressions Review: Percy +1 Review: Code +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions Review: Code +1 (with changes) labels Jul 22, 2024
Copy link
Member

@jmuzina jmuzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@bartaz this is looking good & ready to merge

@bartaz bartaz merged commit 92066e4 into canonical:main Jul 22, 2024
9 checks passed
@bartaz
Copy link
Member

bartaz commented Jul 22, 2024

Thanks @Satishpokala124 for the fix and @jmuzina for review!

@Satishpokala124 Satishpokala124 deleted the remove-bot-contributors branch July 22, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter bots from contributors list
4 participants