Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove discourse module and related routes #5239

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jul 23, 2024

Done

Remove old discourse based routes

Fixes https://warthogs.atlassian.net/browse/WD-12508

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.

@webteam-app
Copy link

@bartaz bartaz added Review: QA needed Review: Code needed Maintenance 🔨 Documentation 📝 Documentation changes or updates Review: Percy needed This PR needs a review of Percy for visual regressions and removed Review: Percy needed This PR needs a review of Percy for visual regressions Documentation 📝 Documentation changes or updates labels Jul 23, 2024
@bartaz bartaz added Documentation 📝 Documentation changes or updates Review: Percy needed This PR needs a review of Percy for visual regressions labels Jul 23, 2024
@bartaz bartaz added Review: Percy needed This PR needs a review of Percy for visual regressions and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Jul 23, 2024
@bartaz bartaz marked this pull request as ready for review July 23, 2024 15:49
@bartaz bartaz removed Documentation 📝 Documentation changes or updates Review: Percy needed This PR needs a review of Percy for visual regressions labels Jul 23, 2024
@jmuzina
Copy link
Member

jmuzina commented Jul 23, 2024

Should we also be able to delete templates/layouts/docs_discourse.html?

@jmuzina jmuzina added the Question ❓ Further information is requested label Jul 23, 2024
@bartaz
Copy link
Member Author

bartaz commented Jul 23, 2024

Should also be able to delete templates/layouts/_docs_discourse.html?

Ah, good catch! It didn't show up in search, because it doesn't contain dicourse 🤦

@jmuzina
Copy link
Member

jmuzina commented Jul 23, 2024

Should also be able to delete templates/layouts/docs_discourse.html?

Ah, good catch! It didn't show up in search, because it doesn't contain dicourse 🤦

I only caught it because I used GH web search and that matches both file contents and names, as I didn't want to check out your fork! Glad it's gone :)

@jmuzina jmuzina added Review: Percy needed This PR needs a review of Percy for visual regressions and removed Review: Percy +1 labels Jul 23, 2024
@jmuzina jmuzina added Review: Code +1 Review: Percy +1 and removed Review: Code needed Question ❓ Further information is requested Review: Percy needed This PR needs a review of Percy for visual regressions labels Jul 23, 2024
Copy link
Member

@jmuzina jmuzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@bartaz bartaz merged commit 90d793a into canonical:main Jul 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants