Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess whitespace in class reference table #5247

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jul 25, 2024

Done

Reduces extra whitespace used by documentation class reference tables.

Previous implementation was using old nested grid implementation. This updates grid as such:

  • Top level grid is now 25/75 split on large instead of 16/58
  • Nested grid is now 33/66 on large and medium instead of 43/57 on large and 40/60 on medium

Fixes #5238, WD-13574

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Before

Large

image

Medium

image

Small

image

After

Large

image

Medium

image

Small

image

@webteam-app
Copy link

@jmuzina jmuzina force-pushed the adjust-class-reference-table-grid branch from 6866967 to 73eee4b Compare July 25, 2024 14:47
@jmuzina jmuzina self-assigned this Jul 25, 2024
@jmuzina jmuzina marked this pull request as ready for review July 25, 2024 14:55
@jmuzina jmuzina added Review: Percy needed This PR needs a review of Percy for visual regressions Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Jul 25, 2024
@bartaz bartaz merged commit 76be152 into canonical:main Jul 29, 2024
13 checks passed
@jmuzina jmuzina deleted the adjust-class-reference-table-grid branch July 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class reference tables have excess whitespace
5 participants