Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --silence-deprecation flag to mute mixed declaration Sass deprecation warnings #5295

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

pastelcyborg
Copy link
Contributor

@pastelcyborg pastelcyborg commented Aug 12, 2024

Done

  • Added --silence-deprecation flag to all Sass build tasks to mute deprecation warnings

Fixes #5264
Fixes WD-13754

QA

  • Checkout this branch
  • Run any package.json build task involving Sass
  • Witness that all deprecation warnings are now muted

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

@jmuzina jmuzina added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Aug 13, 2024
@pastelcyborg pastelcyborg merged commit a7f4cc1 into canonical:main Aug 13, 2024
7 checks passed
@pastelcyborg pastelcyborg deleted the 5264-sass-warnings branch August 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings from sass files
3 participants