-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Percy snapshots by test case name #5299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuzina
force-pushed
the
percy-group-by-test-case-name
branch
from
September 4, 2024 12:24
3afc47a
to
b5f643a
Compare
Browserstack has deployed a fix for our problem with the test case attribute - I've run a test build locally and things look as expected. |
pastelcyborg
approved these changes
Sep 4, 2024
jmuzina
added
Review: Percy needed
This PR needs a review of Percy for visual regressions
Review: Percy +1
and removed
Review: Percy needed
This PR needs a review of Percy for visual regressions
labels
Sep 4, 2024
jmuzina
added a commit
to jmuzina/vanilla-framework
that referenced
this pull request
Sep 4, 2024
This reverts commit 7ff9e82.
1 task
jmuzina
added a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Groups Percy snapshots by example test case name. The example's path relative to repo root (ignoring
standalone/
and query parameters) is used as a test case name.So, for example, given snapshots of
docs/examples/patterns/suru/combined?theme=light
anddocs/examples/standalone/patterns/suru/combined?theme=paper
, both snapshots are grouped underdocs/examples/patterns/suru/combined
This means we can expect each base & pattern test case to have 6 snapshots (3 per color theme in non-standalone, and another 3 in standalone), and all other test cases will have 3 snapshots.
Read Percy blog for more information on this feature.
Fixes WD-13805
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots