-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive image aspect ratio variants #5308
Conversation
I'm not sure what the best way to document the list of aspect ratio classes is here, since there are so many of them (one for each combination of breakpoint and aspect ratio, and another one that applies to all aspect ratios) I've added a table similar to the Grid page: |
A table is good enough, but I would widen the first column to prevent wrapping. Also, might be good to add some explanation as to why we do this - for example, mention that tall aspect ratios can cause a lot of scrolling on mobile, so a change to a less wasteful aspect ratio can be useful. on the other hand, a cinematic format is great when there's sufficient width (at least 9 columns), but for smaller screens, switching to 16x9 or 3x2 might allow more detail to be visible. +1 for easier merging once the above is added |
Updated to use inequalities rather than |
This comment was marked as resolved.
This comment was marked as resolved.
@pastelcyborg I needed to merge Note that image combined example is now screenshotted responsively to test the |
Done
Adds new
-on-(large|medium|small)
variants of each aspect ratio image container class for more precise control over aspect ratios, depending on the screen size.Fixes #5274, WD-13920
QA
width >=1036px
620px >= width < 1036px
width < 620px
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention: