Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advl to team members list #5310

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Aug 19, 2024

Done

Adds @advl to the team members list

Fixes WD-14209

QA

  • Open demo
  • Verify that @advl has been added as an "Engineering Manager"

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Screenshot 2024-08-19 at 9 22 35 AM

@webteam-app
Copy link

@jmuzina jmuzina marked this pull request as ready for review August 19, 2024 13:23
@advl
Copy link

advl commented Aug 19, 2024

Thank you @jmuzina

@jmuzina jmuzina added Review: Percy needed This PR needs a review of Percy for visual regressions Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Aug 19, 2024
@jmuzina jmuzina merged commit 9e1aff3 into canonical:main Aug 19, 2024
12 checks passed
@jmuzina jmuzina deleted the add-advl-to-team branch August 19, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants