Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utility files to use CSS range syntax #5311

Conversation

pastelcyborg
Copy link
Contributor

@pastelcyborg pastelcyborg commented Aug 19, 2024

Done

Fixes #5287
Fixes WD-14040

QA

  • Open the following demos:
  • Ensure correct styles are applied between each breakpoint - the best way to test this is to reduce the browser window to ~1035.5px and ensure styles are applied

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

@pastelcyborg pastelcyborg added Review: QA needed Review: Code needed Bug 🐛 Review: Percy needed This PR needs a review of Percy for visual regressions labels Aug 20, 2024
@pastelcyborg pastelcyborg marked this pull request as ready for review August 20, 2024 00:06
@jmuzina jmuzina added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Aug 20, 2024
@pastelcyborg pastelcyborg merged commit 05272b7 into canonical:main Aug 20, 2024
13 checks passed
@pastelcyborg pastelcyborg deleted the 5287-utility-breakpoints-range-queries branch August 20, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

u-hide utilities' breakpoints deviate from expected screen size values
3 participants