Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually set baseline build commit signature #5340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Sep 11, 2024

Done

#5300 updated the Percy workflow to merge main into a PR before it is tested, but our dual-workflow approach seems to throw a wrench in Percy's baseline build detection: even though the files being tested are a merge of main with a PR, Percy may select a baseline build that is older than the current baseline build, causing false positive test results.

This occurred in #5338 (PR branch was cut from main before merge of #5270). However the Percy build used a baseline build from before the merge of #5270), causing the tree list snapshots to incorrectly appear as new. It appears Percy needs to be manually instructed to use the latest main commit for this two-workflow approach to not have hiccups with merge conflicts. This can be done with environment variables.

This should mean that you only need to merge/rebase branches for Percy tests where source merge conflicts exist.

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants