Implement the Observable spec #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Comments: - caolan#672 (comment)
Requested Changes: - caolan#672 (comment) - caolan#672 (review)
Requested Changes: - caolan#672 (comment) - caolan#672 (comment) - caolan#672 (comment)
…e logic to observableSubscription
vqvu
requested changes
Mar 7, 2019
Requested Changes: - caolan#673 (comment) - caolan#673 (comment) - caolan#673 (comment)
vqvu
approved these changes
Mar 8, 2019
|
Have you verified that this code makes Highland work with Gulp? |
|
Just did: Created gulpfile.js const gulp = require('gulp');
const _ = require('./lib');
gulp.task('list', () => {
return gulp.src('**/*.js')
.pipe(_())
.map(file => file.relative)
.filter(path => !path.includes('node_modules'))
.tap(console.log);
});Executed: gulp listResults: The fact that we see the output wrapped by gulp's timing logger proves that it subscribed to the observable, processed all the files in a stream, and waited for it to complete. We are good to go! 🚀 |
|
Excellent! Thanks for all the work you put in. |
vqvu
changed the title
|
Thank you for all the support and code reviews. I’ve got a few small projects lined up but after I would like to make some progress on v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #672 this is the same solution with a couple of variations for experimentation and discussion:
What do you think @vqvu?