generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description for typescript facet and build script #971
Merged
+23
−18
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7bf8813
Add description for typescript facet and build script
daogrady 496b077
Update node.js/typescript.md
daogrady 123c0d2
Merge branch 'main' into doc/typescript-build-and-facet
daogrady 51df3ad
Update node.js/typescript.md
daogrady 6baca1c
Merge branch 'main' into doc/typescript-build-and-facet
daogrady 88d99a3
Update ts detection mechanism
daogrady c1abd25
Update node.js/typescript.md
daogrady aac7910
Merge branch 'main' into doc/typescript-build-and-facet
renejeglinsky 4e92e05
Update tools/cds-typer.md
daogrady b4e7657
Update node.js/typescript.md
daogrady 0725a7d
Update tools/cds-typer.md
daogrady f095167
Merge branch 'main' into doc/typescript-build-and-facet
daogrady File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daogrady -
outDir
seems to match the default value and might not need to be configured. Reading thevalue from the cds configuration might even be more robust:
path.join(cds.env.build.target, cds.env.folders.srv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I don't think we can dynamically add values here, as this is the recommendation for the basic layout of a tsconfig.json, which is a static file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the
typescript
build task could calculate the default path ifoutDir
isn't set.Of course, this is only an option if
outDir
isn't used by the typescript compiler itself which seems to be the case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are correct about that! 🙂
But this part of the documentation is about a tsconfig.json the user could manually create to configure how the build task works, hence the preamble "We recommend the following basic setup for such a file:".