Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set proper values for titles and descriptions #46

Merged

Conversation

aramovic79
Copy link
Contributor

@aramovic79 aramovic79 commented Aug 27, 2024

Addressing

groups

  • "title": "Catalog Service” → i.e. without appending “ Title”

packages

  • "title": "capire bookshop” → take what is there, don’t add extra text like “sample title for"
  • “shortDescription" → take what is there, don’t add extra text like “Here’s the short description for ..."
  • “description" → take what is there, don’t add extra text like “Here’s the short description for ..."

apiResources

  • "title": "Catalog Service” → take what is there, don’t add extra text like “The service is for ..."
  • “shortDescription": "Catalog Service” → take what is there, don’t add extra text like “Here we have the shortDescription for ..."
  • “description": "Catalog Service” → take what is there, don’t add extra text like “Here we have the description for ..."

from #38

@aramovic79
Copy link
Contributor Author

cc: @ductaily @Fannon

@aramovic79 aramovic79 marked this pull request as ready for review August 28, 2024 11:15
Copy link
Contributor

@RamIndia RamIndia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

lib/templates.js Outdated Show resolved Hide resolved
@RamIndia
Copy link
Contributor

RamIndia commented Sep 5, 2024

@aramovic79 : You can resolve the conflicts and merge this PR.

@aramovic79 aramovic79 merged commit 349a1ce into main Sep 9, 2024
3 checks passed
@aramovic79 aramovic79 deleted the fix/remove-extra-text-added-to-title-and-description branch September 9, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants