Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce disable_ttl parameter #1

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

minhokang242
Copy link
Collaborator


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@minhokang242 minhokang242 force-pushed the users/minhokang/restore_with_ttl_disabled branch from 533a1d9 to 6a9cdc3 Compare February 22, 2024 00:12
@minhokang242 minhokang242 marked this pull request as ready for review February 22, 2024 00:13
Copy link
Owner

@carjackson-msft carjackson-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can you fix the merge conflict in HISTORY.rst please?

@minhokang242 minhokang242 force-pushed the users/minhokang/restore_with_ttl_disabled branch from de92e03 to ebfcbed Compare February 27, 2024 19:49
@minhokang242
Copy link
Collaborator Author

looks good, can you fix the merge conflict in HISTORY.rst please?

Done

@carjackson-msft carjackson-msft merged commit 7d4dc54 into main Feb 27, 2024
1 check passed
carjackson-msft pushed a commit that referenced this pull request Aug 12, 2024
* fix: --title --kind --custom-property parameters (#1)

* feat: support yaml file in register command (#3)

* fix: workspace parameter should not be required (#2)

* style: fix lint issues (#6)

* chore: update codeowner for apic-extension (#5)

* feat: revert changes to min cli version (#4)

* feat: resolve comments to CLI experience (#10)

* feat: mark "apic api register" command as preview (Azure#13)

* feat: remove --terms-of-service parameter (Azure#12)

* feat: remove --workspace-name parameter (#11)

* feat: support python 3.8 and 3.9 (Azure#14)

* feat: fix command descriptions (Azure#17)

* tests: add test cases for 'apic service' commands (Azure#16)

* feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (Azure#19)

* fix: CLI errors (Azure#20)

* fix: import error when run CLI command

* fix: no workspace name error when run import specification command

* feat: mark some parameters as required (Azure#21)

* feat: mark --assignments parameter required for metadata commands

* doc: update sample commands

* feat: mark --source-resource-ids parameter as required for import-from-apim command

* doc: update description for import-from-apim command

* feat: bump version to 1.0.0b5 and update changelog (Azure#18)

* build: fix ci (Azure#22)

* style: fix style warnings

* test:fix test cases

* fix: service update command failure (Azure#28)

* doc: fix command samples (Azure#30)

* doc: update changelog per feedback (Azure#29)

* doc: remove extra spaces in register command help message (Azure#34)

* doc: update api definition and metadata command samples (Azure#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants