[WIP] 04ization #19
Closed
[WIP] 04ization #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing. However, I don't really see how this has anything to do with the Options dependency: can you clarify? It seems to be mainly about using a It also has conflicts now since I merged #18, but those are easy to fix. |
|
No worries! I am still working on this. Pulling out Options was not as trivial as I initially thought, so it has been taking some time to understand the surrounding code. Do you think the idiom/performance improvements should be separate PRs? Otherwise, I'll ping you when this is ready. |
sjkelly
force-pushed
the
sjk/04ization
branch
from
3552931
to
dcaef8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is targeting 0.3 and 0.4. The primary objective is to eliminate the Options dependency and enable precompilation.