-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultipleChoiceFilter does not use lookup_type #49
Comments
This is very true and could easily be addressed by the above code. But, should a |
Forget the question... I can see possible use cases, although there might be alternatives. Maybe something where the choices are used with an |
I'm going to close this as Out of Scope for the moment. Happy to consider documented, tested pull requests. We may have capacity to reconsider in the future. |
Is your offer still open? Adding |
Hey @rixx! Yep. Very happy to look at a PR here. (Thanks! 🤹♂️) |
This was requested in #49 (back when lookup_expr was called lookup_type). This is a minor change, with the added advantage of making ``MultipleChoiceFilter`` perform more like other Filter classes, down to the explicit ``__exact`` filter. As the documentation only mentions ``lookup_expr`` to be available on Filter classes in general, and doesn't mention ``MultipleChoiceFilter`` to be different, no documentation change is necessary.
MultipleChoiceFilter.filter() should be updated to include something along these lines:
I haven't really taken a good look at any of the code, so this is just my initial solution.
The text was updated successfully, but these errors were encountered: