Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timezone on DateRangeField #1660

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove timezone on DateRangeField #1660

wants to merge 6 commits into from

Conversation

Thutmose3
Copy link

@Thutmose3 Thutmose3 commented May 14, 2024 •
edited
Loading

Date ranges should not be made timezone aware

#1659

@Thutmose3 Thutmose3 mentioned this pull request May 14, 2024
Open
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  django_filters
  fields.py
Project Total  

This report was generated by python-coverage-comment-action

carltongibson
carltongibson reviewed Aug 27, 2024
View reviewed changes
Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add regression tests for the change here please? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thutmose3 @carltongibson