Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OrderingFilter.help_text #757

Merged
merged 2 commits into from
Aug 9, 2017

Conversation

rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Aug 7, 2017

Fixes #756.

@codecov-io
Copy link

codecov-io commented Aug 7, 2017

Codecov Report

Merging #757 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #757      +/-   ##
===========================================
+ Coverage    98.13%   98.13%   +<.01%     
===========================================
  Files           15       15              
  Lines         1125     1126       +1     
===========================================
+ Hits          1104     1105       +1     
  Misses          21       21
Impacted Files Coverage Δ
django_filters/filters.py 98.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f69e35...8d529ad. Read the comment docs.

@carltongibson carltongibson added this to the Version 1.1 milestone Aug 9, 2017
@carltongibson carltongibson merged commit 22682ee into carltongibson:develop Aug 9, 2017
@rpkilby rpkilby deleted the ordering-helptext branch August 9, 2017 15:15
carltongibson pushed a commit that referenced this pull request Oct 19, 2017
* Remove confusing help text for OrderingFilter

* Add OrderingFilter/SelectMultiple incompat note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants