Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception message for invalid filter result #943

Merged
merged 2 commits into from
Jul 13, 2018
Merged

Improve exception message for invalid filter result #943

merged 2 commits into from
Jul 13, 2018

Commits on Jul 13, 2018

  1. Improve exception message for invalid filter calls 

    The current exception is an AttributeError that lacks any context about
the filter call. e.g., "NoneType has no attribute filter". This message
is improved by including which filterset and which filter are incorrect.
    Ryan P Kilby committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    fa8addc View commit details
    Browse the repository at this point in the history

  2. Fix tests broken by new exception

    Ryan P Kilby committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    cd81823 View commit details
    Browse the repository at this point in the history