Updates toolchain to a more recent 2023-03-25 #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRoussac
approved these changes
Jun 1, 2023
Fraser999
suggested changes
Jun 1, 2023
Comment on lines
+844
to
+847
| const EXPECTED_FAUCET_INSTALL_COST: u64 = 75_226_865_930; | ||
| const EXPECTED_FAUCET_SET_VARIABLES_COST: u64 = 579_464_060; | ||
| const EXPECTED_FAUCET_CALL_BY_INSTALLER_COST: u64 = 3_040_141_320; | ||
| const EXPECTED_FAUCET_CALL_BY_USER_COST: u64 = 3_242_199_690; |
There was a problem hiding this comment.
As per the comment above these consts, could you update the table in the indicated README too please?
Fraser999
approved these changes
Jun 1, 2023
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps a toolchain for contract API to more recent 2023-03-25. This is not the most recent, as the current nightly appears to produce non-mvp WebAssembly opcodes which are not supported on our platform. Apparently this version update also decerases gas cost on average in our tests.
See also upstream compiler issue here: rust-lang/rust#109807