Update rpm, migrate to clap and add source_date_epoch flag

[newpavlov]

While clap-based code is somewhat heavier than getopts, it's more powerful and results in cleaner and easier to maintain code.

This PR also fixes a bunch of Clippy warnings and introduces the source-date flag necessary for reproducible builds.

I am not completely sure I got the extra metadata stuff correctly, so it's better to double check it.

Closes #82

[newpavlov]

@cat-in-136
I would appreciate if you will give feedback on this PR before I spend time on resolving the conflicts.

[cat-in-136]

@newpavlov To resolve #82, the prerequisite is that the next version of rpm-rs/rpm have been released so that the git path does not have to be written to the Cargo.toml dependency. Other than that, some trivial work is required, such as updating README.md. In other words, there is still some work to be done.

On the other hand, if you remove the "source_date_epoch flag" and "closes #82" from this PR / branch, it is thought to be almost ready to merge.

What you do with it is up to you. Because you are a committer of rpm-rs/rpm.

---

Your clap branch cargo-generate-rpm works differently between cargo-generate-rpm and cargo generate-rpm. You can see this in the behavior of cargo-generate-rpm --help and cargo generate-rpm --help.

Some other cargo subcommands actually have this behavior, but I'd like to stick with it for compatibility with previous behavior and because it works properly with cargo tauri (which uses clap).

[newpavlov]

I guess rpm v0.12 will be released only after rpm-rs/rpm#159 gets resolved, so it will take a bit of time.

Your clap branch cargo-generate-rpm works differently between cargo-generate-rpm and cargo generate-rpm.

Do you have suggestions how it can be fixed? Personally, I dislike the subcommand workaround as well, but I couldn't find an easy way to fix it.

[cat-in-136]

Do you have suggestions how it can be fixed? Personally, I dislike the subcommand workaround as well, but I couldn't find an easy way to fix it.

@newpavlov Here is the short snippet to do same thing as cargo-tauri does.

use clap::Parser;

#[derive(Debug, Parser)]
#[command(name = "cargo")]
#[command(bin_name = "cargo")]
enum CargoCli {
    Foobarbaz(FoobarbazArgs),
}

#[derive(Debug, Parser)]//<--- instead of clap::Args, use clap::Parser derive.
#[command(name = "cargo-foobarbaz")]
#[command(bin_name = "cargo-foobarbaz")]
#[command(author, version, about, long_about = None)]
struct FoobarbazArgs {
    #[arg(long)]
    foo: Option<String>,
}

fn main() {
    let args = if let Some("foobarbaz") = std::env::args().nth(1).as_deref() {
        CargoCli::parse()
    } else {
        CargoCli::Foobarbaz(FoobarbazArgs::parse())
    };
    println!("{args:?}");
}

[newpavlov]

@cat-in-136
rpm v0.12 was published, so this PR is ready for review/merge.

[cat-in-136]

@newpavlov Can you check my review comment above?

[newpavlov]

Do you mean the difference between calling cargo-generate-rpm and cargo generate-rpm? I think I've already fixed it. Or have I missed something?

[cat-in-136]

I have already confirmed that the issue of cargo-generate-rpm and cargo generate-rpm is resolved in following code.

    let mut args = std::env::args();
    let args = if let Some("generate-rpm") = args.nth(1).as_deref() {
        let CargoWrapper::GenerateRpm(args) = CargoWrapper::parse();
        args
    } else {
        Cli::parse()
    };

[cat-in-136]

Thanks a lot.