Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test static taxonomies #139

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Test static taxonomies #139

merged 2 commits into from
Sep 15, 2023

Conversation

zschira
Copy link
Member

@zschira zschira commented Sep 14, 2023

This PR addresses #138. This issue outlines occasional CI failures caused by flakiness when downloading taxonomies. It seems occasionally while downloading taxonomies, some files will not be downloaded successfully, which then impacts the extraction process. Adding archived taxonomies, and using these in integration tests should solve this problem.

@zschira zschira linked an issue Sep 14, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.16% 🎉

Comparison is base (da63a8c) 91.77% compared to head (e1ada6a) 91.94%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   91.77%   91.94%   +0.16%     
==========================================
  Files           8        8              
  Lines         596      596              
==========================================
+ Hits          547      548       +1     
+ Misses         49       48       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaneselvans zaneselvans added the xbrl Data published in the eXtensible Business Reporting Language, a dialect of XML used by FERC and SEC label Sep 14, 2023
@zschira zschira merged commit 3a1da11 into main Sep 15, 2023
10 checks passed
@zschira zschira deleted the test_static_taxonomies branch September 15, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
xbrl Data published in the eXtensible Business Reporting Language, a dialect of XML used by FERC and SEC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proportion of lost facts in tests seems non-deterministic
2 participants