Update dependencies to allow pandas 2.2 and improve performance #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zaneselvans
commented
Jan 20, 2024
•
zaneselvans
commented
- Allow use of pandas 2.2
- Require pyarrow, which will be required by pandas 3.0, and now raises a deprecation warning. Should also improve string performance in some use cases.
zaneselvans
added
xbrl
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 8 8
Lines 610 610
=======================================
Hits 570 570
Misses 40 40 ☔ View full report in Codecov by Sentry. |
- Allow use of pandas 2.2 - Require pyarrow, which will be required in pandas 3.0 and now raises a deprecation warning if it is not available. Should also improve string performance in some use cases.
zaneselvans
force-pushed
the
pandas-2.2
branch
from
82af906
to
ea584da
Compare
zaneselvans
commented
Jan 20, 2024
There was a problem hiding this comment.
Most of the changes in here are because my TOML linter went to town.
Comment on lines
-7
to
+9
| - pip>=21.0,<24 | ||
| - pip>=21.0 | ||
| - python>=3.10,<3.13 | ||
| - setuptools>=66,<69 | ||
| - setuptools>=66 |
There was a problem hiding this comment.
Unnecessarily restrictive.
| "setuptools_scm[toml]>=3.5.0", | ||
| "wheel", | ||
| ] | ||
| requires = ["setuptools>=66", "setuptools_scm[toml]>=3.5.0", "wheel"] |
There was a problem hiding this comment.
Allow most recent version of setuptools.
Comment on lines
-21
to
-29
| "pydantic>=2,<3", | ||
| "coloredlogs>=14.0,<15.1", | ||
| "arelle-release>=2.3,<3", | ||
| "coloredlogs>=14.0,<15.1", | ||
| "frictionless>=4.4,<5", | ||
| "lxml>=4.9.1,<6", | ||
| "numpy>=1.16,<2", | ||
| "pandas>=1.5,<3", | ||
| "pyarrow>=14.0.1", # required starting in pandas 3.0 | ||
| "pydantic>=2,<3", | ||
| "sqlalchemy>=1.4,<3", | ||
| "pandas>=1.5,<2.2", | ||
| "stringcase>=1.2,<2", | ||
| "numpy>=1.16,<2", | ||
| "lxml>=4.9.1,<6", |
There was a problem hiding this comment.
Only real changes here are allowing pandas 2.2 and requiring pyarrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.