Skip to content

Commit

Permalink
Update to macos-12 GHA image
Browse files Browse the repository at this point in the history
Since the last time, macos-12 has fixed the toolchain's linker
crash bug, so we can update here. macos-13 has a new and exciting
bug when unwinding exceptions in binaries compiled with GCC, so
we cannot update all the way at this time.
  • Loading branch information
horenmar committed Jul 22, 2024
1 parent 381f29e commit 595bf98
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/mac-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@ on: [push, pull_request]

jobs:
build:
# macos-12 updated to a toolchain that crashes when linking the
# test binary. This seems to be a known bug in that version,
# and will eventually get fixed in an update. After that, we can go
# back to newer macos images.
runs-on: macos-11
runs-on: macos-12
strategy:
matrix:
cxx:
Expand All @@ -29,8 +25,6 @@ jobs:
env:
CXX: ${{matrix.cxx}}
CXXFLAGS: ${{matrix.cxxflags}}
# Note: $GITHUB_WORKSPACE is distinct from ${{runner.workspace}}.
# This is important
run: |
cmake -Bbuild -H$GITHUB_WORKSPACE \
-DCMAKE_BUILD_TYPE=${{matrix.build_type}} \
Expand Down

0 comments on commit 595bf98

Please sign in to comment.