Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation failures with the latest MSVC v142 toolchain (Visual Studio 16.6.0) #1934

Closed
VioletGiraffe opened this issue May 20, 2020 · 2 comments
Closed

Compilation failures with the latest MSVC v142 toolchain (Visual Studio 16.6.0) #1934

VioletGiraffe opened this issue May 20, 2020 · 2 comments
Labels
Bug

Comments

@VioletGiraffe
Copy link

VioletGiraffe commented May 20, 2020 •
edited
Loading

Must be due to this change shipped in 16.6

I was wrong, it must be this one: "Removing C++17-Deprecated Features In C++20". You will need /std:c++latest to reproduce the error, which is caused by std::result_of not being available anymore.
@VioletGiraffe
Copy link
Author

Workaround: define macro _HAS_DEPRECATED_RESULT_OF=1

@horenmar horenmar added the Bug label May 21, 2020
@horenmar
Copy link
Member

Oh, nevermind, that doesn't actually fix it, master just doesn't properly test benchmarking.

@horenmar horenmar reopened this May 21, 2020
nitnelave pushed a commit to nitnelave/Catch2 that referenced this issue May 25, 2020
@horenmar @nitnelave
Avoid using std::result_of when std::invoke_result is available
7874e6c 
Closes catchorg#1934
nitnelave pushed a commit to nitnelave/Catch2 that referenced this issue May 25, 2020
@horenmar @nitnelave
Really fix use of std::result_of when invoke_result is available
d1f1224 
Closes catchorg#1934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VioletGiraffe @horenmar