-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(impl):[210] added cache mechanism to ConnectorEndpointsService #623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See at the suggested change to fix the helm template issues.
Please also address the code smells
@@ -114,6 +114,8 @@ data: | |||
operator: {{ .operator | quote }} | |||
rightOperand: {{ .rightOperand | quote }} | |||
{{- end }} | |||
connectorEndpointService: | |||
cacheTTL: {{ tpl(.Values.edc.connectorEndpointService.cacheTTL) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cacheTTL: {{ tpl(.Values.edc.connectorEndpointService.cacheTTL) }} | |
cacheTTL: {{ .Values.edc.connectorEndpointService.cacheTTL | int64 }} |
SonarCloud Quality Gate failed. 0 Bugs 0.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@@ -196,7 +196,8 @@ edc: | |||
- leftOperand: "Membership" | |||
operator: "eq" | |||
rightOperand: "active" | |||
|
|||
connectorEndpointService: | |||
cacheTTL: 86400000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to iso format
add comment
Added cache mechanism to feat(impl):[210] added cache mechanism to ConnectorEndpointsService, added TTL configuration via helm