Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#206 update ess documentation #669

Merged
merged 12 commits into from
Dec 5, 2023

Conversation

ds-jhartmann
Copy link

No description provided.

Copy link

CHANGELOG file was not updated! Make sure to include important changes.

ds-ext-kmassalski

This comment was marked as outdated.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@ds-ext-kmassalski
Copy link

Changelog conflict :)

ds-psosnowski
ds-psosnowski previously approved these changes Dec 4, 2023
Copy link

@ds-psosnowski ds-psosnowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -16,14 +16,14 @@ The Item Relationship Service (IRS) is the first reference application of the Da

### Requirements
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify if this document is used somewhere or could be deleted.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not part of the story I would like to move this discussion to a later time so I can merge this PR and close the story


This work is licensed under the [Apache-2.0](https://www.apache.org/licenses/LICENSE-2.0).
This work is licensed under the https://www.apache.org/licenses/LICENSE-2.0[Apache-2.0].
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct, I assume Apache2.0 ??

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct. Links in AsciiDoc are different from links in markdown. Markdown syntax is [Display Text](url), AsciiDoc syntax is url[Display Text]

docs/src/uml-diagrams/deployment-view/level-0-dev.puml Outdated Show resolved Hide resolved
Co-authored-by: ds-mkanal <100209308+mkanal@users.noreply.github.com>
mkanal
mkanal previously approved these changes Dec 5, 2023
…ss-documentation

# Conflicts:
#	charts/irs-helm/CHANGELOG.md
#	charts/irs-helm/templates/configmap-spring-app-config.yaml
#	irs-api/src/main/resources/application.yml
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ds-jhartmann ds-jhartmann merged commit 09e6f15 into main Dec 5, 2023
@ds-jhartmann ds-jhartmann deleted the feature/#206-update-ess-documentation branch December 5, 2023 12:41
ds-jhartmann added a commit that referenced this pull request May 27, 2024
…ry-client-2.1.0-SNAPSHOT

Update irs-registry-client to 2.1.0-SNAPSHOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants