-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#206 update ess documentation #669
Conversation
CHANGELOG file was not updated! Make sure to include important changes. |
Changelog conflict :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -16,14 +16,14 @@ The Item Relationship Service (IRS) is the first reference application of the Da | |||
|
|||
### Requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify if this document is used somewhere or could be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is not part of the story I would like to move this discussion to a later time so I can merge this PR and close the story
|
||
This work is licensed under the [Apache-2.0](https://www.apache.org/licenses/LICENSE-2.0). | ||
This work is licensed under the https://www.apache.org/licenses/LICENSE-2.0[Apache-2.0]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct, I assume Apache2.0 ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is correct. Links in AsciiDoc are different from links in markdown. Markdown syntax is [Display Text](url)
, AsciiDoc syntax is url[Display Text]
Co-authored-by: ds-mkanal <100209308+mkanal@users.noreply.github.com>
…ss-documentation # Conflicts: # charts/irs-helm/CHANGELOG.md # charts/irs-helm/templates/configmap-spring-app-config.yaml # irs-api/src/main/resources/application.yml
Kudos, SonarCloud Quality Gate passed! |
…ry-client-2.1.0-SNAPSHOT Update irs-registry-client to 2.1.0-SNAPSHOT
No description provided.