Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(collection):[#TRI-996] Correct param "jobStates" in collection … #837

Merged
merged 1 commit into from
Mar 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ _**For better traceability add the corresponding GitHub issue number in each cha
- Added role "admin_irs" again

### Changed
- Deprecated query parameter 'jobStates' was removed from GET {{IRS_HOST}}/irs/jobs endpoint
- Deprecated query parameter 'jobStates' was removed from GET {{IRS_HOST}}/irs/jobs endpoint. TRI-996
- Moved OAuth2 JWT token claim to configuration. The fields can be configured with `oauth.resourceClaim`, `oauth.irsNamespace`, `oauth.roles`.
- ESS
- Added Tombstone to ESS investigation in case required aspect models "PartAsPlanned" or "PartSiteInformationAsPlanned" are missing
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ref over IRS, DTRegistry, DAPS, "SubmodelServer AssemblyPartRelationship)"
end ref

loop 100 times
ESRSubServer --> IRS: GET /irs/jobs?jobStates=COMPLETED
ESRSubServer --> IRS: GET /irs/jobs?states=COMPLETED
ESRSubServer <-- IRS: jobList
alt jobId is in jobList
ESRSubServer --> IRS: GET /irs/jobs{jobId}
Expand Down
14 changes: 7 additions & 7 deletions local/testing/request-collection/IRS_Request_Collection.json
Original file line number Diff line number Diff line change
Expand Up @@ -1384,7 +1384,7 @@
"body": {},
"parameters": [
{
"name": "jobStates",
"name": "states",
"value": "COMPLETED",
"disabled": false
}
Expand Down Expand Up @@ -1425,7 +1425,7 @@
"body": {},
"parameters": [
{
"name": "jobStates",
"name": "states",
"value": "ERROR",
"disabled": false
}
Expand Down Expand Up @@ -1466,7 +1466,7 @@
"body": {},
"parameters": [
{
"name": "jobStates",
"name": "states",
"value": "INITIAL",
"disabled": false
}
Expand Down Expand Up @@ -1542,7 +1542,7 @@
"body": {},
"parameters": [
{
"name": "jobStates",
"name": "states",
"value": "RUNNING",
"disabled": false
}
Expand Down Expand Up @@ -2019,20 +2019,20 @@
"body": {},
"parameters": [
{
"name": "jobStates",
"name": "states",
"value": "ERROR",
"disabled": true,
"id": "pair_c694b66f41e649db837f801b5699859e"
},
{
"name": "jobStates",
"name": "states",
"value": "CANCELED,COMPLETED",
"disabled": false,
"id": "pair_ab346623e5394504b7232cc40ae75bed"
},
{
"id": "pair_ddbccd5219944e8cac3d99249ba881e5",
"name": "jobStates",
"name": "states",
"value": "RUNNING",
"description": "",
"disabled": true
Expand Down