Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix README shared_context code given for testing #183

Conversation

esquinas
Copy link
Contributor

@esquinas
Copy link
Contributor Author

Maybe in the future you could provide the test helper like this instead of in the README

# spec/support/shared_examples/axlsx.rb

require "caxlsx_rails/test_helper"
# ...

@straydogstudio
Copy link
Collaborator

@esquinas Do you know what Rails version this became effective in?

If it is new enough, it would be good to comment out the old line and indicate what version of Rails it is used in.

@esquinas
Copy link
Contributor Author

@straydogstudio I think this is independent of the Rails version. We use this gem and it failed during CI/CD just by doing a dependabot update of caxlsx_rails from 0.6.3 to 0.6.4
Now, in older Rails versions, the AxlsxRails::TemplateHandle class is going to be available because it belongs to the gem, not to Rails.

@timdiggins
Copy link
Contributor

@straydogstudio I can confirm same thing for me.

FYI The change to the namespace & name of the class came in #164

@esquinas
Copy link
Contributor Author

@straydogstudio Sorry to insist, I write again just to make sure you are not waiting for me to solve the failed CI tests.

I am not solving them because the failed CI tests look like flaky setup stuff like this:

An error occurred while installing sqlite3 (1.6.9), and Bundler cannot continue.

In Gemfile.rails-5.2:
  sqlite3
Error: The process '/opt/hostedtoolcache/Ruby/2.4.10/x64/bin/bundle' failed with exit code 5

I think/hope the failures will go away if you re-run the Github actions. I do not have permissions to re-run them (or I cannot find where to click)

Thanks.

@straydogstudio straydogstudio merged commit 1472939 into caxlsx:master Jul 23, 2024
34 of 36 checks passed
@straydogstudio
Copy link
Collaborator

@esquinas Yeah it does seem like flaky setup. It is always ruby 2.4. So far rerunning hasn't helped.

I'll add it anyway for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants