fix out-of-bounds issue for certificate response.

fix #97 Signed-off-by: Yang, Longlong <longlong.yang@intel.com>
ccc-spdm-tools · Jun 13, 2024 · 59aa578 · 59aa578
1 parent 5c89fff
commit 59aa578
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/spdmlib/src/requester/encap_certificate.rs b/spdmlib/src/requester/encap_certificate.rs
@@ -101,7 +101,7 @@ impl RequesterContext {
         }
 
         let offset = get_certificate.offset;
-        if offset > my_cert_chain.data_size {
+        if offset >= my_cert_chain.data_size {
             self.encode_encap_error_response(
                 SpdmErrorCode::SpdmErrorInvalidRequest,
                 0,

diff --git a/spdmlib/src/responder/certificate_rsp.rs b/spdmlib/src/responder/certificate_rsp.rs
@@ -125,7 +125,7 @@ impl ResponderContext {
         }
 
         let offset = get_certificate.offset;
-        if offset > my_cert_chain.data_size {
+        if offset >= my_cert_chain.data_size {
             self.write_spdm_error(SpdmErrorCode::SpdmErrorInvalidRequest, 0, writer);
             return (
                 Err(SPDM_STATUS_INVALID_MSG_FIELD),