Skip to content

Commit

Permalink
Add length check when take(rsp_length)
Browse files Browse the repository at this point in the history
Signed-off-by: OuyangHang33 <hank.ouyang@intel.com>
  • Loading branch information
OuyangHang33 authored and jyao1 committed May 30, 2024
1 parent c724476 commit 9916d65
Showing 1 changed file with 15 additions and 10 deletions.
25 changes: 15 additions & 10 deletions spdmlib/src/message/vendor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -160,17 +160,22 @@ impl Codec for VendorDefinedRspPayloadStruct {

fn read(r: &mut Reader) -> Option<VendorDefinedRspPayloadStruct> {
let rsp_length = u16::read(r)?;
let mut vendor_defined_rsp_payload = [0u8; MAX_SPDM_VENDOR_DEFINED_PAYLOAD_SIZE];
for d in vendor_defined_rsp_payload
.iter_mut()
.take(rsp_length as usize)
{
*d = u8::read(r)?;
if rsp_length as usize > MAX_SPDM_VENDOR_DEFINED_PAYLOAD_SIZE {
log::error!("invalid rsp length!!!\n");
None
} else {
let mut vendor_defined_rsp_payload = [0u8; MAX_SPDM_VENDOR_DEFINED_PAYLOAD_SIZE];
for d in vendor_defined_rsp_payload
.iter_mut()
.take(rsp_length as usize)
{
*d = u8::read(r)?;
}
Some(VendorDefinedRspPayloadStruct {
rsp_length,
vendor_defined_rsp_payload,
})
}
Some(VendorDefinedRspPayloadStruct {
rsp_length,
vendor_defined_rsp_payload,
})
}
}

Expand Down

0 comments on commit 9916d65

Please sign in to comment.