Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix artifactory access using the correct option (NO_JIRA) #17

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix artifactory access using the correct option (NO_JIRA) #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/Darwin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
---
- name: Check for existing Xcode installation

Check failure on line 2 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

fqcn[action-core] 

Use FQCN for builtin module actions (stat).
stat:
path: "/Applications/Xcode_{{ xcode_version }}.app"
register: xcode_app

- name: "Download XCode {{ xcode_version }}"

Check failure on line 7 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

fqcn[action-core] 

Use FQCN for builtin module actions (shell).

Check failure on line 7 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

no-changed-when 

Commands should not change things if nothing needs doing.
shell: >
jfrog rt dl
--flat
Expand All @@ -12,7 +12,7 @@
--retries=100
"--url=https://artifactory.ccdc.cam.ac.uk/artifactory"
"--user={{ ansible_deployment_artifactory_user }}"
"--access-token={{ ansible_deployment_artifactory_key }}"
"--password={{ ansible_deployment_artifactory_key }}"
"ccdc-3rdparty-macos-xcode-installers/Xcode_{{ xcode_version }}.xip"
~/Downloads/
environment:
Expand All @@ -22,7 +22,7 @@
when: xcode_app.stat.isdir is not defined or not xcode_app.stat.isdir
register: download

- name: Extract XCode archive

Check failure on line 25 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

fqcn[action-core] 

Use FQCN for builtin module actions (command).
command: xip -x ~/Downloads/Xcode_{{ xcode_version }}.xip
args:
chdir: "/Applications"
Expand All @@ -30,7 +30,7 @@
when: xcode_app.stat.isdir is not defined or not xcode_app.stat.isdir
register: extract_xcode_xip

- name: Move XCode to /Applications/Xcode_{{ xcode_version }}.app

Check failure on line 33 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

fqcn[action-core] 

Use FQCN for builtin module actions (command).

Check failure on line 33 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

name[template] 

Jinja templates should only be at the end of 'name'
command: mv /Applications/Xcode.app /Applications/Xcode_{{ xcode_version }}.app
when: xcode_app.stat.isdir is not defined or not xcode_app.stat.isdir

Expand Down
Loading