Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding scripts from 2017 mof subset paper NO_JIRA #60

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

sbwiggin
Copy link
Contributor

@sbwiggin sbwiggin commented Jul 2, 2024

  • Added scripts from https://pubs.acs.org/doi/10.1021/acs.chemmater.7b00441 with minor tweaks so the scripts can find the ccdc solvent folder from the new installation file structure
  • Added a ReadMe.md for the scripts
  • Updated the scripts folder ReadMe.md to include the new scripts (and re-arranged to alphabetical script order)
  • Also updated a different script ReadMe that I was using as a reference as VS Code highlighted some markdown syntax issues

@sbwiggin sbwiggin requested review from Alex-AMC and pmbulit July 2, 2024 15:30
Copy link

sonarcloud bot commented Jul 2, 2024

For example:
"hydrogen bond"
For example:
"hydrogen bond"

<img src="../assets/search.gif" width="500px">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD033/no-inline-html Inline HTML [Element: img]

For example:
"hydrogen bond"
For example:
"hydrogen bond"

<img src="../assets/search.gif" width="500px">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD045/no-alt-text Images should have alternate text (alt text)

@sbwiggin sbwiggin merged commit 4b3129d into main Jul 2, 2024
5 checks passed
@sbwiggin sbwiggin deleted the add_scripts_from_2017_mof_subset_paper branch July 2, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants