Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Migrate to new page layout #28

Conversation

alisonelizabeth
Copy link

@alisonelizabeth alisonelizabeth commented Jun 7, 2021

This PR migrates Upgrade Assistant to use the new page layout.

Related to elastic#100748

Screenshots

Overview page:
Screen Shot 2021-06-07 at 12 53 50 PM
Screen Shot 2021-06-07 at 1 55 43 PM

ES deprecations:
Screen Shot 2021-06-07 at 1 01 54 PM
Screen Shot 2021-06-07 at 1 07 18 PM
Screen Shot 2021-06-07 at 1 16 37 PM

Kibana deprecations:
Screen Shot 2021-06-07 at 1 00 23 PM
Screen Shot 2021-06-07 at 1 00 43 PM
Screen Shot 2021-06-07 at 2 19 14 PM
Screen Shot 2021-06-07 at 2 19 57 PM

@alisonelizabeth
Copy link
Author

@cchaos would you mind taking an initial look at this? Should the error/empty states also be centered when used within tabs (see screenshots under "Elasticsearch" section)?

@cchaos
Copy link
Owner

cchaos commented Jun 7, 2021

These pages look great! I think ideally, the empty and loading states are always centered, but I'd even go further and get rid of the whole page header when in the "Ready to Upgrade" state and move those CTA buttons to the actions portion of EuiEmptyPrompt like:

image

And maybe soften the loading state when under tabs by removing the panel color for those specific cases.

I'm hoping we'll get to a point where all these decisions will be held by the template and you'd just be able to specify what kind of state you're in. But I'm encouraged by your question, so thank you!

@alisonelizabeth
Copy link
Author

Thanks @cchaos! I'm going to close this PR in favor of elastic#101691, and will address your feedback there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants