Fix build with GHC-7.10.3 #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously I would see the following build failure:
$ cabal-3.0 build -w ghc-7.10.3
Resolving dependencies...
Build profile: -w ghc-7.10.3 -O1
In order, the following will be built (use -v for more details):
- pretty-simple-3.1.0.0 (lib:pretty-simple) (first run)
Warning: pretty-simple.cabal: Ignoring unknown section type: custom-setup
Configuring pretty-simple-3.1.0.0...
setup: At least the following dependencies are missing:
aeson -any, bytestring -any, optparse-applicative -any
haskell/cabal#3881 seems related but
I don't fully understand the issue.
|
@sjakobi Thanks for this fix. pretty-simple isn't officially supported on GHC < 8.0, but this is a very simple change, so I'll merge it in! In case anyone else runs into this, here is the error you get when trying to build with ghc-7.10.3 (and cabal-install 3.0.0.0): $ cabal new-build
Resolving dependencies...
Build profile: -w ghc-7.10.3 -O1
In order, the following will be built (use -v for more details):
- ansi-terminal-0.10.2 (lib) (requires download & build)
- cabal-doctest-1.0.8 (lib) (requires download & build)
- pretty-simple-3.1.1.0 (lib:pretty-simple) (first run)
Downloading ansi-terminal-0.10.2
Downloaded ansi-terminal-0.10.2
Downloading cabal-doctest-1.0.8
Starting ansi-terminal-0.10.2 (lib)
Downloaded cabal-doctest-1.0.8
Starting cabal-doctest-1.0.8 (lib)
Building ansi-terminal-0.10.2 (lib)
Building cabal-doctest-1.0.8 (lib)
Installing cabal-doctest-1.0.8 (lib)
Completed cabal-doctest-1.0.8 (lib)
Installing ansi-terminal-0.10.2 (lib)
Completed ansi-terminal-0.10.2 (lib)
[1 of 1] Compiling Main ( /home/illabout/git/pretty-simple/dist-newstyle/build/x86_64-linux/ghc-7.10.3/pretty-simple-3.1.1.0/setup/setup.hs, /home/illabout/git/pretty-simple/dist-newstyle/build/x86_64-linux/ghc-7.10.3/pretty-simple-3.1.1.0/setup/Main.o ) [Distribution.Extra.Doctest changed]
Linking /home/illabout/git/pretty-simple/dist-newstyle/build/x86_64-linux/ghc-7.10.3/pretty-simple-3.1.1.0/setup/setup ...
Warning: pretty-simple.cabal: Ignoring unknown section type: custom-setup
Configuring pretty-simple-3.1.1.0...
setup: At least the following dependencies are missing:
aeson -any, bytestring -any, optparse-applicative -any |
cdepillabout
added a commit
that referenced
this pull request
Dec 2, 2019
Oh, I wasn't aware! The bound on I'm using |
|
Thank you! :) |
Ah, thanks. Maybe I should bump the bound at some point. Although I guess pretty-simple is, well... simple enough that supporting old GHCs isn't too much work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I would see the following build failure:
haskell/cabal#3881 seems related but
I don't fully understand the issue.