fix(api-object): cross-module-version instanceof is broken
#1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spion
force-pushed
the
fix/api-object-instanceof
branch
from
b06c472
to
65fc05f
Compare
This pull fixes the issue with instanceof (cdk8s-team#581) by implementing Symbol.hasInstance (thanks to @fikisipi for pointing it out) Docs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/hasInstance Signed-off-by: Gjorgji Kjosev <gorgi.kosev@gmail.com>
spion
force-pushed
the
fix/api-object-instanceof
branch
from
65fc05f
to
364e395
Compare
iliapolo
changed the title
instanceof is broken
Signed-off-by: Gjorgji Kjosev <gorgi.kosev@gmail.com>
Signed-off-by: Gjorgji Kjosev <gorgi.kosev@gmail.com>
spion
force-pushed
the
fix/api-object-instanceof
branch
from
fbb3355
to
726d98c
Compare
iliapolo
approved these changes
Mar 13, 2023
cdk8s-automation
pushed a commit
that referenced
this pull request
Mar 13, 2023
This pull request fixes the issue with `instanceof` (#581) by implementing `Symbol.hasInstance` (thanks to @fikisipi for pointing it out) Docs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/hasInstance I welcome any ideas on how to write tests demonstrating the issue is fixed, as to set things up one needs to have multiple versions (or instances) of the same module. Fixes #581 (cherry picked from commit fea71cc) Signed-off-by: Gorgi Kosev <gorgi.kosev@gmail.com>
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mergify bot
pushed a commit
that referenced
this pull request
Mar 13, 2023
…1121) # Backport This will backport the following commits from `2.x` to `1.x`: - [fix(api-object): cross-module-version `instanceof` is broken (#1112)](#1112) ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue with
instanceof(#581) by implementingSymbol.hasInstance(thanks to @fikisipi for pointing it out)Docs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/hasInstance
I welcome any ideas on how to write tests demonstrating the issue is fixed, as to set things up one needs to have multiple versions (or instances) of the same module.
Fixes #581