-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Serverless Nag Pack #1793
base: main
Are you sure you want to change the base?
feat: Serverless Nag Pack #1793
Conversation
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Test Suites: 50 passed, 50 total |
|
100% code coverage on all the rules, all the rules have been unit tested on L1 and L2 constructs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a large change thus I will go through multiple iterations of reviews.
In addition to the proposed changes to descriptions, please link this PR to the issue you created
}; | ||
|
||
/** | ||
* Ensure that API Gateway REST and HTTP APIs are using JSON structured logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explanations on all the rules need to be written in a declarative manner.
* Ensure that API Gateway REST and HTTP APIs are using JSON structured logs | |
* API Gateway REST and HTTP APIs use JSON structured logs |
*/ | ||
private checkLambda(node: CfnResource) { | ||
this.applyRule({ | ||
info: 'The Lambda function should have tracing set to Tracing.ACTIVE', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all need to be re-written to be both declarative and resource specific.
Example
info: 'The Lambda function should have tracing set to Tracing.ACTIVE', | |
info: 'The Lambda function does not have tracing set to Tracing.ACTIVE', |
Fixes #