Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: tags should include module name #26

Closed
eladb opened this issue Feb 2, 2021 · 1 comment
Closed

go: tags should include module name #26

eladb opened this issue Feb 2, 2021 · 1 comment

Comments

@eladb
Copy link
Contributor

eladb commented Feb 2, 2021

For example, for github.com/aws/constructs-go, Instead of v3.3.1 the tag should be constructs/v3.3.1.

This technically allows different modules in the same repo to be tagged with different versions.

Reference: https://research.swtch.com/vgo-module#multiple-module_repositories

In the major subdirectory convention, v2/ contains the module “my/thing/v2”. A natural extension is to allow subdirectories not named for major versions. For example, we could add a blue/ subdirectory that contains the module “my/thing/blue”, confirmed by a blue/go.mod file with that module path. In this case, the source control commit tags addressing that module would take the form blue/v1.x.x. Similarly, the tag blue/v2.x.x would address the blue/v2/ subdirectory. The existence of the blue/go.mod file excludes the blue/ tree from the outer my/thing module.

@iliapolo
Copy link
Contributor

iliapolo commented Feb 2, 2021

Resolved by #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants