Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Go Into Build cdk8s #2444

Closed
MrArnoldPalmer opened this issue Jan 20, 2021 · 2 comments · Fixed by cdk8s-team/cdk8s#523
Closed

Integrate Go Into Build cdk8s #2444

MrArnoldPalmer opened this issue Jan 20, 2021 · 2 comments · Fixed by cdk8s-team/cdk8s#523
Assignees
@eladb
Labels
effort/medium Medium work item – a couple days of effort feature-request A feature should be added or improved. p2
Milestone
Go Sprint Jan 20 ...

Comments

@MrArnoldPalmer
Copy link
Contributor

Add Go code generation for cdk8s packages and add go module publishing to jsii-release workflow.
@MrArnoldPalmer MrArnoldPalmer added feature-request A feature should be added or improved. effort/medium Medium work item – a couple days of effort p2 labels Jan 20, 2021
@MrArnoldPalmer MrArnoldPalmer mentioned this issue Jan 20, 2021
Closed
5 tasks
@eladb eladb self-assigned this Jan 20, 2021
@eladb eladb changed the title Integrate Go Into Build and Publishing of cdk8s Integrate Go Into Build cdk8s Jan 20, 2021
@eladb eladb removed their assignment Jan 20, 2021
@eladb eladb assigned eladb and unassigned eladb Jan 20, 2021
@eladb
Copy link
Contributor

eladb commented Feb 2, 2021

Currently blocked on #2506 and cdklabs/publib#26

@eladb eladb self-assigned this Feb 4, 2021
@eladb eladb mentioned this issue Feb 4, 2021
Merged
eladb pushed a commit to cdk8s-team/cdk8s that referenced this issue Feb 4, 2021
feat: experimental golang bindings (#523)
6737351 
Build & publishes experimental Go bindings for CDK8s under `github.com/awslabs/cdk8s-go/cdk8s` and `github.com/awslabs/cdk8s-go/cdk8splus17`.

This required the following changes:
- Add `publishToGo` definitions to `cdk8s` and `cdk8s-plus-17`
- Upgrading constructs to 3.3.5 (which is available in go)
- Remove the use of `_` as a parameter name due to aws/jsii#2530



Resolves aws/jsii#2444
Resolves aws/jsii#2454
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
effort/medium Medium work item – a couple days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
Go Sprint Jan 20 - Feb 10 2021
Development

Successfully merging a pull request may close this issue.

feat: experimental golang bindings cdk8s-team/cdk8s
2 participants
@eladb @MrArnoldPalmer