Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup a couple Hugo warnings. #2104

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fixup a couple Hugo warnings. #2104

merged 1 commit into from
Apr 1, 2021

Conversation

dj2
Copy link
Contributor

@dj2 dj2 commented Apr 1, 2021

Summary | Résumé

  • Fix .URL -> .Permalink warning
  • Fix .Dir -> .File.Dir warning

Issue #2052

Test instructions | Instructions pour tester la modification

This touches on the index, partnership and tools-and-resources pages so those are the one's you'll want to verify.

Unresolved questions / Out of scope | Questions non résolues ou hors sujet

The .File.Dir zero object warning remains, I've been unable to figure
out how to fix it. It's currently triggered in each of the 3 places we
use .File.Dir.

Reviewer checklist | Liste de vérification du réviseur

  • Have you tested it? | L’avez-vous testé?
  • Does this break existing functionality? | Est-ce que ça brise une fonctionnalité existante?
  • Should this be split into smaller PRs to decrease change risk? | Est-ce que ça devrait être divisé en de plus petites demandes de tirage (« pull requests ») afin de réduire le risque lié aux modifications?

 * Fix .URL -> .Permalink warning
 * Fix .Dir -> .File.Dir warning

The .File.Dir zero object warning remains, I've been unable to figure
out how to fix it. It's currently triggered in each of the 3 places we
use .File.Dir.

Issue #2052
@dj2 dj2 requested a review from brdunfield April 1, 2021 15:07
@dj2 dj2 self-assigned this Apr 1, 2021
Copy link
Contributor

@brdunfield brdunfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦑

@dj2 dj2 temporarily deployed to digital-cana-warn-zq2wep0vgo0h April 1, 2021 16:36 Inactive
@dj2 dj2 merged commit b87b42d into cds-snc:master Apr 1, 2021
@dj2 dj2 deleted the warn branch April 1, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants