Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing content with new Hugo. #2311

Merged
merged 7 commits into from
Jun 3, 2021
Merged

Fix missing content with new Hugo. #2311

merged 7 commits into from
Jun 3, 2021

Conversation

dj2
Copy link
Contributor

@dj2 dj2 commented May 31, 2021

Summary | Résumé

It seems with newer Hugo the main page needs to use .Site.Pages
instead of .Pages in order for the page content to show up.

This seems to also pull in the folder as a data item, it's fine for the
products as they have an onhomepage filter. For the blog posts I added
in a filter to make sure there was a author tag in order to filter
out the folder.

Issue #2052

@dj2 dj2 requested a review from brdunfield May 31, 2021 20:24
@dj2 dj2 self-assigned this May 31, 2021
@maxneuvians maxneuvians temporarily deployed to digital-cana-pages-20pcgn8x8qa May 31, 2021 20:25 Inactive
layouts/index.html Outdated Show resolved Hide resolved
dj2 added 2 commits June 2, 2021 10:38
It seems with newer Hugo the main page needs to use `.Site.Pages`
instead of `.Pages` in order for the page content to show up.

This seems to also pull in the folder as a data item, it's fine for the
products as they have an `onhomepage` filter. For the blog posts I added
in a filter to make sure there was a `processed` tag in order to filter
out the folder.

Issue #2052
@dj2 dj2 temporarily deployed to digital-cana-pages-20pcgn8x8qa June 2, 2021 14:42 Inactive
@dj2 dj2 requested a review from brdunfield June 2, 2021 14:44
brdunfield
brdunfield previously approved these changes Jun 2, 2021
Copy link
Contributor

@brdunfield brdunfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - content on the homepage looks the same as the live site!

@dj2 dj2 temporarily deployed to digital-cana-pages-20pcgn8x8qa June 2, 2021 19:16 Inactive
@dj2 dj2 temporarily deployed to digital-cana-pages-20pcgn8x8qa June 2, 2021 19:49 Inactive
@dj2 dj2 temporarily deployed to digital-cana-pages-20pcgn8x8qa June 2, 2021 19:51 Inactive
@dj2 dj2 temporarily deployed to digital-cana-pages-20pcgn8x8qa June 2, 2021 19:56 Inactive
@dj2 dj2 requested a review from brdunfield June 2, 2021 19:59
@brdunfield brdunfield temporarily deployed to digital-cana-pages-20pcgn8x8qa June 3, 2021 13:23 Inactive
Copy link
Contributor

@brdunfield brdunfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dj2 dj2 merged commit ce1d0c4 into master Jun 3, 2021
@dj2 dj2 deleted the pages branch June 3, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants