-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing content with new Hugo. #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brdunfield
reviewed
Jun 1, 2021
It seems with newer Hugo the main page needs to use `.Site.Pages` instead of `.Pages` in order for the page content to show up. This seems to also pull in the folder as a data item, it's fine for the products as they have an `onhomepage` filter. For the blog posts I added in a filter to make sure there was a `processed` tag in order to filter out the folder. Issue #2052
brdunfield
previously approved these changes
Jun 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - content on the homepage looks the same as the live site!
brdunfield
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
It seems with newer Hugo the main page needs to use
.Site.Pages
instead of
.Pages
in order for the page content to show up.This seems to also pull in the folder as a data item, it's fine for the
products as they have an
onhomepage
filter. For the blog posts I addedin a filter to make sure there was a
author
tag in order to filterout the folder.
Issue #2052