Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typescript errors #16

Merged
merged 19 commits into from
Jun 4, 2020
Merged

Fix Typescript errors #16

merged 19 commits into from
Jun 4, 2020

Commits on Jun 3, 2020

  1. Fix public mocks

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    ae0f4e5 View commit details
    Browse the repository at this point in the history

  2. Fix empty states types

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    ce70c87 View commit details
    Browse the repository at this point in the history

  3. Fix engine table component errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    bba99b1 View commit details
    Browse the repository at this point in the history

  4. Fix engine overview component errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    be1de63 View commit details
    Browse the repository at this point in the history

  5. Fix setup guide component errors 

    - SetBreadcrumbs will be fixed in a separate commit
    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    6942284 View commit details
    Browse the repository at this point in the history

  6. Fix App Search index errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    a6b347e View commit details
    Browse the repository at this point in the history

  7. Fix engine overview header component errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    5e0e275 View commit details
    Browse the repository at this point in the history

  8. Fix applications context index errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    30cb1dd View commit details
    Browse the repository at this point in the history

  9. Fix kibana breadcrumb helper errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    caa808e View commit details
    Browse the repository at this point in the history

  10. Fix license helper errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    143f280 View commit details
    Browse the repository at this point in the history

  11. ❗ Refactor React Router EUI link/button helpers 

    - in order to fix typescript errors

- this changes the component logic significantly to a react render prop, so that the Link and Button components can have different types - however, end behavior should still remain the same
    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    ffa46c5 View commit details
    Browse the repository at this point in the history

  12. Fix telemetry helper errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    0f66185 View commit details
    Browse the repository at this point in the history

  13. Minor unused var cleanup in plugin files

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    fc6c7ae View commit details
    Browse the repository at this point in the history

  14. Fix telemetry collector/savedobjects errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    dc02e93 View commit details
    Browse the repository at this point in the history

  15. Fix MockRouter type errors and add IRouteDependencies export 

    - routes will use IRouteDependencies in the next few commits
    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    b6bde5e View commit details
    Browse the repository at this point in the history

  16. Fix engines route errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    9f0a123 View commit details
    Browse the repository at this point in the history

  17. Fix telemetry route errors

    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    6c6ce21 View commit details
    Browse the repository at this point in the history

  18. Remove any type from source code 

    - thanks to Scotty for the inspiration
    @cee-chen
    cee-chen committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    e5dcd5f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Add eslint rules for Enterprise Search plugin 

    - Add checks for type any, but only on non-test files
- Disable react-hooks/exhaustive-deps, since we're already disabling it in a few files and other plugins also have it turned off
    @cee-chen
    cee-chen committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    fa5ecda View commit details
    Browse the repository at this point in the history