CI: Disable buggy skipping of duplicate runs #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fknorr
force-pushed
the
disable-skip-ci
branch
from
9aac3fd
to
008f883
Compare
psalz
approved these changes
Oct 11, 2022
dentarg
added a commit
to dentarg/puma
that referenced
this pull request
Jun 5, 2024
From https://github.com/fkirc/skip-duplicate-actions?tab=readme-ov-file#concurrent_skipping > Skip a workflow run if the same workflow is already running but it does not seem reliable, for example, this workflow run https://github.com/puma/puma/actions/runs/9386209788 looks 100% green but that is because everything was skipped https://github.com/fkirc/skip-duplicate-actions/issues has many reports about problems with `concurrent_skipping` celerity/celerity-runtime#148 is an example of another project disabling it. [ci skip]
dentarg
added a commit
to puma/puma
that referenced
this pull request
Jun 5, 2024
From https://github.com/fkirc/skip-duplicate-actions?tab=readme-ov-file#concurrent_skipping > Skip a workflow run if the same workflow is already running but it does not seem reliable, for example, this workflow run https://github.com/puma/puma/actions/runs/9386209788 looks 100% green but that is because everything was skipped https://github.com/fkirc/skip-duplicate-actions/issues has many reports about problems with `concurrent_skipping` celerity/celerity-runtime#148 is an example of another project disabling it. [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug, the fkirc/skip-duplicate-actions incorrectly identifies
pull_requestas duplicates topushtriggers based on identical base branches, even though pull requests run will on an implicit merge commit.This temporarily disables skipping of concurrent runs. We keep cancellation of known-outdated runs when a newer commit was pushed on the same branch.