Skip to content

Commit

Permalink
re order CI jobs to make lint the last
Browse files Browse the repository at this point in the history
it was decided long ago and it let the unit and integrations tests run fast for faster feedback loop
  • Loading branch information
auvipy committed Apr 13, 2021
1 parent c7ba31d commit fd4dfa4
Showing 1 changed file with 24 additions and 23 deletions.
47 changes: 24 additions & 23 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: CI
on: [pull_request, push]
jobs:
#################### Linters and checkers ####################
lint:
#################### Unittests ####################
unittest:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.8]
python-version: [3.6,3.7,3.8]
steps:
- name: Install system packages
run: sudo apt update && sudo apt-get install libcurl4-openssl-dev libssl-dev
Expand All @@ -19,19 +19,15 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: pip install --upgrade pip setuptools wheel tox tox-docker
- name: Run flake8
run: tox -v -e flake8 -- -v
- name: Run pydocstyle
run: tox -v -e pydocstyle -- -v
- name: Run apicheck
run: tox -v -e apicheck -- -v
#################### Unittests ####################
unittest:
needs: lint
- name: Run unittest
run: tox -v -e ${{ matrix.python-version }}-linux-unit -- -v
#################### Integration tests ####################
integration:
needs: [unittest]
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.6,3.7,3.8]
python-version: [3.6,3.7,3.8,pypy3]
steps:
- name: Install system packages
run: sudo apt update && sudo apt-get install libcurl4-openssl-dev libssl-dev
Expand All @@ -44,15 +40,18 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: pip install --upgrade pip setuptools wheel tox tox-docker
- name: Run unittest
run: tox -v -e ${{ matrix.python-version }}-linux-unit -- -v
#################### Integration tests ####################
integration:
needs: [lint, unittest]
- name: Run AMQP integration tests
run: tox -v -e ${{ matrix.python-version }}-linux-integration-py-amqp -- -v
- name: Run redis integration tests
run: tox -v -e ${{ matrix.python-version }}-linux-integration-py-redis -- -v

#################### Linters and checkers ####################
lint:
needs: [unittest, integration]
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.6,3.7,3.8,pypy3]
python-version: [3.8]
steps:
- name: Install system packages
run: sudo apt update && sudo apt-get install libcurl4-openssl-dev libssl-dev
Expand All @@ -65,7 +64,9 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: pip install --upgrade pip setuptools wheel tox tox-docker
- name: Run AMQP integration tests
run: tox -v -e ${{ matrix.python-version }}-linux-integration-py-amqp -- -v
- name: Run redis integration tests
run: tox -v -e ${{ matrix.python-version }}-linux-integration-py-redis -- -v
- name: Run flake8
run: tox -v -e flake8 -- -v
- name: Run pydocstyle
run: tox -v -e pydocstyle -- -v
- name: Run apicheck
run: tox -v -e apicheck -- -v

0 comments on commit fd4dfa4

Please sign in to comment.