add accept parameter to SimpleQueue class

[lsaavedr]

please add 'accept' parameter to SimpleQueue class

[auvipy]

please add tests

[drsantos20]

Do we already have tests to cover this? can we update? Just let me know and i can help you

[matusvalo]

Hi @drsantos20. You can start adding tests here: https://github.com/celery/kombu/blob/60dc3456368a06ed4125ea9eac9c06e7fcf5cffe/t/unit/test_simple.py

I would put it to Both test_SimpleQueue and test_SimpleBuffer classes.

[matusvalo]

I have added unittests and fixed slightly the PR. Please review. @celery/core-developers

[maybe-sybr]

A few minor changes which I think would make this better. I'd also like to see a test for what happens if we pass in an empty list/set for the accept kwarg.

[maybe-sybr]

Why has this lost the **kwargs passthrough? We still accept them in the method signature so I assume we still need to pass them along to be cooperative.

[matusvalo]

The kwargs are redundant. If you have a look to __init__ definition of parent class you will see parameters only that are explicitly used:

 16 class SimpleBase:
 17     Empty = Empty
 18     _consuming = False
 19
 20     def __enter__(self):
 21         return self
 22
 23     def __exit__(self, *exc_info):
 24         self.close()
 25
 26     def __init__(self, channel, producer, consumer, no_ack=False, accept=None):

hence the **kwargs is totally useless here.

[matusvalo]

I'd also like to see a test for what happens if we pass in an empty list/set for the accept kwarg.
done.

@maybe-sybr I have implemented your comments.

[maybe-sybr]

lgtm, thanks @matusvalo

[maybe-sybr]

We haven't done an RC for kombu like we have with celery, so this could arguably land but I'll leave that to @thedrow since he's managing the releases.