Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pidbox not using default channels on 4.x branch #1256

Closed
wants to merge 3 commits into from
Closed

Fix pidbox not using default channels on 4.x branch #1256

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9ae51f
Update dev requirements for 4.x branch
lambacck Oct 7, 2020
5c08827
Test default channel gets used
lambacck Oct 7, 2020
8fa3fbf
Fix pidbox not using default channels
lambacck Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .python-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.6.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is purpose of this file? Is it needed in PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope that's an accidental add because of pyenv.

4 changes: 2 additions & 2 deletions requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
https://github.com/celery/py-amqp/zipball/master
https://github.com/celery/vine/zipball/master
https://github.com/celery/py-amqp/zipball/v2.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really need to be changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master for those projects has dropped support for Python 2.7 and Python 3.5. This pins the dev-dependencies for the 4.x branch here to the branches in those projects so that kombu 4 (and thus Celery 4) can maintain support for python 2.7 and 3.5 in the spirit of the LTS branch declared with the release of Celery 5.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related, it seems that brotli on windows needs some kind of pinning to make it continue to work for python 2.7 but I didn't want to dig too hard into what that was. That's why appveyor tests are failing.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it will work with 1.0.7 based on this: google/brotli#848

https://github.com/celery/vine/zipball/1.0
5 changes: 4 additions & 1 deletion t/unit/asynchronous/test_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@ def setup(self):
self.hub = Hub()

def teardown(self):
self.hub.close()
try:
self.hub.close()
except IOError:
pass

def test_reset(self):
self.hub.close = Mock(name='close')
Expand Down